From bd3321e879918d280f6183c98a388886c88b13c0 Mon Sep 17 00:00:00 2001 From: Edwin Eefting Date: Sun, 23 Feb 2020 23:36:34 +0100 Subject: [PATCH] actually set canmount=noauto instead of filtering it. --- bin/zfs-autobackup | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/zfs-autobackup b/bin/zfs-autobackup index fed4dad..8f027fb 100755 --- a/bin/zfs-autobackup +++ b/bin/zfs-autobackup @@ -1350,7 +1350,7 @@ class ZfsAutobackup: # parser.add_argument('--destroy-stale', action='store_true', help='Destroy stale backups that have no more snapshots. Be sure to verify the output before using this! ') parser.add_argument('--clear-refreservation', action='store_true', help='Filter "refreservation" property. (recommended, safes space. same as --filter-properties refreservation)') - parser.add_argument('--clear-mountpoint', action='store_true', help='Filter "canmount" property. You still have to set canmount=noauto on the backup server. (recommended, prevents mount conflicts. same as --filter-properties canmount)') + parser.add_argument('--clear-mountpoint', action='store_true', help='Set property canmount=noauto for new datasets. (recommended, prevents mount conflicts. same as --set-properties canmount=noauto)') parser.add_argument('--filter-properties', type=str, help='List of propererties to "filter" when receiving filesystems. (you can still restore them with zfs inherit -S)') parser.add_argument('--set-properties', type=str, help='List of propererties to override when receiving filesystems. (you can still restore them with zfs inherit -S)') parser.add_argument('--rollback', action='store_true', help='Rollback changes on the target before starting a backup. (normally you can prevent changes by setting the readonly property on the target_path to on)') @@ -1450,7 +1450,7 @@ class ZfsAutobackup: filter_properties.append("refreservation") if self.args.clear_mountpoint: - filter_properties.append("canmount") + set_properties.append( "canmount=noauto" ) fail_count=0 for source_dataset in source_datasets: