patrick/zfs_autobackup
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pre/post snapshot polishing. still needs test-scripts

Browse Source
This commit is contained in:
Edwin Eefting
2021-06-18 17:16:18 +02:00
parent 1286bfafd0
commit 84437ee1d0
3 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zfs_autobackup/ZfsAutobackup.py
View File

@ -511,8 +511,8 @@ class ZfsAutobackup:
self.set_title("Snapshotting")
source_node.consistent_snapshot(source_datasets, source_node.new_snapshotname(),
min_changed_bytes=self.args.min_change,
pre_snapshot_cmd=self.args.pre_snapshot_cmd,
post_snapshot_cmd=self.args.post_snapshot_cmd)
pre_snapshot_cmds=self.args.pre_snapshot_cmd,
post_snapshot_cmds=self.args.post_snapshot_cmd)
################# sync
# if target is specified, we sync the datasets, otherwise we just thin the source. (e.g. snapshot mode)

14
zfs_autobackup/ZfsNode.py
View File

@ -162,7 +162,7 @@ class ZfsNode(ExecuteNode):
"""determine uniq new snapshotname"""
return self.backup_name + "-" + time.strftime("%Y%m%d%H%M%S")
def consistent_snapshot(self, datasets, snapshot_name, min_changed_bytes, pre_snapshot_cmd=[], post_snapshot_cmd=[]):
def consistent_snapshot(self, datasets, snapshot_name, min_changed_bytes, pre_snapshot_cmds=[], post_snapshot_cmds=[]):
"""create a consistent (atomic) snapshot of specified datasets, per pool.
"""
@ -193,7 +193,7 @@ class ZfsNode(ExecuteNode):
return
try:
for cmd in pre_snapshot_cmd:
for cmd in pre_snapshot_cmds:
self.verbose("Running pre-snapshot-cmd")
self.run(cmd=shlex.split(cmd), readonly=False)
@ -207,9 +207,15 @@ class ZfsNode(ExecuteNode):
self.run(cmd, readonly=False)
finally:
for cmd in post_snapshot_cmd:
for cmd in post_snapshot_cmds:
self.verbose("Running post-snapshot-cmd")
self.run(cmd=shlex.split(cmd), readonly=False, valid_exitcodes=[])
try:
self.run(cmd=shlex.split(cmd), readonly=False)
except Exception as e:
pass
self.warning("Post snapshot command failed, ignoring.")
def selected_datasets(self, exclude_received, exclude_paths):
"""determine filesystems that should be backed up by looking at the special autobackup-property, systemwide